search

darianhickman / VillageMakeover

Village Makeover is a nonprofit fundraising platform. As you build your online village, the money you spend builds real villages. For example buy a well for your village and you donate to construction of a real well in Ndola Zambia. At present all donations are managed through Seeds of Hope International Partners (www.sohip.org).
http://www.villagethegame.com
1 stars 1 forks source link

Backgrounds of description don't fit #41

Open darianhickman opened 9 years ago

darianhickman commented 9 years ago

The backgrounds don't encompass the text. What can we do to clean up the appearance here?

screen shot 2015-05-07 at 10 48 45 am

umutnacak commented 9 years ago

Yeah I had stated this issue last week, in #38 I think: There is a small issue in the engine. measureTextWidth method of the IgeFontSheet.js returns measuredWidth instead of maxWidth. Since engine code is in .gitignore I guess you need to manually edit the code in the production server. Line 144 -> return maxWidth;

darianhickman commented 9 years ago

Ok hopefully it's fixed in the latest and greatest isogenic if not can you do a pull request to the ige repo?

umutnacak commented 9 years ago

I am not sure about that. And I am not sure that if we upgrade to a new version we won't see any broken features. I could create a pull req. for this fix though.

darianhickman commented 9 years ago

Ok thanks for looking into it On Fri, May 8, 2015 at 6:04 AM umutnacak notifications@github.com wrote:

I am not sure about that. And I am not sure that if we upgrade to a new version we won't see any broken features. I could create a pull req. for this fix though.

— Reply to this email directly or view it on GitHub https://github.com/darian311/VillageMakeover/issues/41#issuecomment-100225878 .