search

darianhickman / VillageMakeover

Village Makeover is a nonprofit fundraising platform. As you build your online village, the money you spend builds real villages. For example buy a well for your village and you donate to construction of a real well in Ndola Zambia. At present all donations are managed through Seeds of Hope International Partners (www.sohip.org).
http://www.villagethegame.com
1 stars 1 forks source link

Safari error #7

Closed umutnacak closed 9 years ago

umutnacak commented 9 years ago

I am getting this error in Safari: ReferenceError: Can't find variable: TouchEvent

Mac OS X 10.10.2 Safari 8.0.4

darianhickman commented 9 years ago

Is this blocking game play? On Wed, Mar 18, 2015 at 1:17 PM umutnacak notifications@github.com wrote:

I am getting this error in Safari: ReferenceError: Can't find variable: TouchEvent

Mac OS X 10.10.2 Safari 8.0.4

— Reply to this email directly or view it on GitHub https://github.com/darian311/VillageMakeover/issues/7.

umutnacak commented 9 years ago

Yes. I will investigate more today.

umutnacak commented 9 years ago

Ok, so this is because of fool moron's pinchzoomcomponent. According to this document: https://developer.mozilla.org/en-US/docs/Web/Guide/Events/Touch_events TouchEvent is only supported in Chrome for Desktop. Adding the following condition to mouse events seems like fixes the issue: typeof TouchEvent !== 'undefined' I didn't make a thorough test but let's say this is the issue, should I alter PinchZoomComponent.js?

darianhickman commented 9 years ago

What are the chances it will break the scroll to zoom?

On Thu, Mar 19, 2015 at 8:35 AM, umutnacak notifications@github.com wrote:

Ok, so this is because of fool moron's pinchzoomcomponent. According to this document: https://developer.mozilla.org/en-US/docs/Web/Guide/Events/Touch_events TouchEvent is only supported in Chrome for Desktop. Adding the following condition to mouse events seems like fixes the issue: typeof TouchEvent !== 'undefined' I didn't make a thorough test but let's say this is the issue, should I alter PinchZoomComponent.js?

— Reply to this email directly or view it on GitHub https://github.com/darian311/VillageMakeover/issues/7#issuecomment-83538109 .

Darian Hickman | (310) 439-8573 | http://www.linkedin.com/in/darianhickman

umutnacak commented 9 years ago

I don't think it will break anything. Did you download the component from a github repo? Maybe we should tell the developer to fix this issue. Otherwise we need to fix this, because the game is unplayable in browsers other than Chrome. Did you test in other browsers?

On Thu, Mar 19, 2015 at 4:19 PM, Darian Hickman notifications@github.com wrote:

What are the chances it will break the scroll to zoom?

On Thu, Mar 19, 2015 at 8:35 AM, umutnacak notifications@github.com wrote:

Ok, so this is because of fool moron's pinchzoomcomponent. According to this document: https://developer.mozilla.org/en-US/docs/Web/Guide/Events/Touch_events TouchEvent is only supported in Chrome for Desktop. Adding the following condition to mouse events seems like fixes the issue: typeof TouchEvent !== 'undefined' I didn't make a thorough test but let's say this is the issue, should I alter PinchZoomComponent.js?

— Reply to this email directly or view it on GitHub < https://github.com/darian311/VillageMakeover/issues/7#issuecomment-83538109

.

Darian Hickman | (310) 439-8573 | http://www.linkedin.com/in/darianhickman

— Reply to this email directly or view it on GitHub https://github.com/darian311/VillageMakeover/issues/7#issuecomment-83599060 .

darianhickman commented 9 years ago

I think he's responsive so let him fix first

Sent from my iPhone

On Mar 19, 2015, at 11:11 AM, umutnacak notifications@github.com wrote:

I don't think it will break anything. Did you download the component from a github repo? Maybe we should tell the developer to fix this issue. Otherwise we need to fix this, because the game is unplayable in browsers other than Chrome. Did you test in other browsers?

On Thu, Mar 19, 2015 at 4:19 PM, Darian Hickman notifications@github.com wrote:

What are the chances it will break the scroll to zoom?

On Thu, Mar 19, 2015 at 8:35 AM, umutnacak notifications@github.com wrote:

Ok, so this is because of fool moron's pinchzoomcomponent. According to this document: https://developer.mozilla.org/en-US/docs/Web/Guide/Events/Touch_events TouchEvent is only supported in Chrome for Desktop. Adding the following condition to mouse events seems like fixes the issue: typeof TouchEvent !== 'undefined' I didn't make a thorough test but let's say this is the issue, should I alter PinchZoomComponent.js?

— Reply to this email directly or view it on GitHub < https://github.com/darian311/VillageMakeover/issues/7#issuecomment-83538109

.

Darian Hickman | (310) 439-8573 | http://www.linkedin.com/in/darianhickman

— Reply to this email directly or view it on GitHub https://github.com/darian311/VillageMakeover/issues/7#issuecomment-83599060 .

— Reply to this email directly or view it on GitHub.

darianhickman commented 9 years ago

Can we remove pinch zoom altogether ? I want to focus on polished desktop experience and ignore mobile til better funding comes through

Sent from my iPhone

On Mar 19, 2015, at 11:11 AM, umutnacak notifications@github.com wrote:

I don't think it will break anything. Did you download the component from a github repo? Maybe we should tell the developer to fix this issue. Otherwise we need to fix this, because the game is unplayable in browsers other than Chrome. Did you test in other browsers?

On Thu, Mar 19, 2015 at 4:19 PM, Darian Hickman notifications@github.com wrote:

What are the chances it will break the scroll to zoom?

On Thu, Mar 19, 2015 at 8:35 AM, umutnacak notifications@github.com wrote:

Ok, so this is because of fool moron's pinchzoomcomponent. According to this document: https://developer.mozilla.org/en-US/docs/Web/Guide/Events/Touch_events TouchEvent is only supported in Chrome for Desktop. Adding the following condition to mouse events seems like fixes the issue: typeof TouchEvent !== 'undefined' I didn't make a thorough test but let's say this is the issue, should I alter PinchZoomComponent.js?

— Reply to this email directly or view it on GitHub < https://github.com/darian311/VillageMakeover/issues/7#issuecomment-83538109

.

Darian Hickman | (310) 439-8573 | http://www.linkedin.com/in/darianhickman

— Reply to this email directly or view it on GitHub https://github.com/darian311/VillageMakeover/issues/7#issuecomment-83599060 .

— Reply to this email directly or view it on GitHub.

umutnacak commented 9 years ago

It's your call :) I'm going to disable it in the next commit. You can enable it whenever you want.

darianhickman commented 9 years ago

As long experience on desktop is good we can keep going forward On Thu, Mar 19, 2015 at 12:03 PM umutnacak notifications@github.com wrote:

It's your call :) I'm going to disable it in the next commit. You can enable it whenever you want.

— Reply to this email directly or view it on GitHub https://github.com/darian311/VillageMakeover/issues/7#issuecomment-83644179 .

umutnacak commented 9 years ago

Pinch zoom component is disabled in this commit: 02ee50d6528349e684546804669558f455d53e00 I'm closing this issue for now, you can address this at a later time.