search

darickc / MMM-BackgroundSlideshow

MIT License
135 stars 78 forks source link

Photos not being resized #105

Closed bobcoup closed 2 years ago

bobcoup commented 2 years ago

Hi

Great module!

I am probably doing something wrong but photos don't seem to be resized. I am running MagicMirror on an official Raspberry Pi 7" touchscreen (800x480).

Here are the settings in config.js:

{ module: 'MMM-BackgroundSlideshow', position: 'fullscreen_below', config: { imagePaths: ['/mnt/photos/'], recursiveSubDirectories: true, transitionImages: true, randomizeImageOrder: true, resizeImages: true, maxWidth: 800, maxHeight: 480, slideshowSpeed: 20000 } }, Is the maxWidth and maxHeight correct?

Thanks.

jritsema commented 2 years ago

Looking at the code, resizeImages, maxWidth, and maxHeight don't appear to be implemented at all 👎

darickc commented 2 years ago

They are used in node_helper.js

jritsema commented 2 years ago

They are used in node_helper.js

Oh OK, sorry about that. The resizing doesn't seem to work for me and I didn't see any references to it in the code, so I just assumed...

I'll try updating to the latest version and try again.

jritsema commented 2 years ago

I'll try updating to the latest version and try again.

Verified that the latest version is working for me now 👍

darickc commented 2 years ago

Good to hear.