Not Responding to Notifications

[acer8888]

Hello, I'm using On Screen Menu (https://github.com/shbatm/MMM-OnScreenMenu) Module to send notifications with a onscreen button to Background Slide Show. I can see the notifications being sent using View Notifications Module (https://github.com/glitch452/MMM-ViewNotifications), but Slideshow is not performing the action in the notifications. I'm using the notifications "BACKGROUNDSLIDESHOW_PAUSE" & "BACKGROUNDSLIDESHOW_PLAY".

Any thought on how to troubleshoot?

Thanks in advanced for your help!

[Crazylegstoo]

I can confirm this bug, as well. What has happened is that the code that identifies notifications has been moved from the notificationReceived function to the socketNotificationReceived function. In fact, the notificationReceived function is completely empty, meaning the module is not processing any custom notifications!

This is a change from previous release of the module code. I know this for a fact because I had a mirror that was issuing BACKGROUNDSLIDESHOW_NEXT and BACKGROUNDSLIDESHOW_PREVIOUS and it worked fine for years. I recently rebuilt my mirror with updated code and found I could no longer control the slideshow in terms of next/previous. This is when I discovered the code is no longer supporting notifications at all.

I suspect this was maybe not intentional. I think it can be fixed by simply relocating some pieces of code to the notificationReceived function so that the module will respond to notifications once more.

[rts58]

I looked through the changes in code. The Aug 2022 commit is where the the notificationReceived code was moved to socketNotificationReceived. I went back to the earlier 68a665f commit and now BACKGROUNDSLIDESHOW_NEXT and BACKGROUNDSLIDESHOW_PREVIOUS are working properly.

[drdada]

It's because of the socketNotification is not receiving the core notifications I did a quick and dirty fix https://github.com/darickc/MMM-BackgroundSlideshow/pull/135