Bugfix/48 multiple clients

darickc / MMM-BackgroundSlideshow

MIT License

135 stars 78 forks source link

Bugfix/48 multiple clients #143

Closed crazyscot closed 6 months ago

crazyscot commented 7 months ago

This fixes #48 in my use case, but...

I have moved the timer from MMM-BackgroundSlideshow.js into node_helper.js
Doing so broke the (undocumented) feature where a file ending in .mp4 or .m4v was played using omxplayer
- ... but that cannot possibly work when run outside of a raspi
- ... but that was maybe broken anyway, as omxplayer seems to have been removed from the repositories?
- ... so I removed that feature altogether.

So I would entirely understand if you don't want to merge this.

KristjanESPERANTO commented 6 months ago

@crazyscot Thanks for the PR! Can you put the part which fixes #48 in an separate PR?

Since omxplayer is deprecated, I find the step to remove the functionality understandable. But maybe there is an alternative. That's why I think it would be good to separate the two things.

crazyscot commented 6 months ago

OK, I have rebased my PR to master, and dropped the commits that remove the omxplayer functionality.