search

darickc / MMM-BackgroundSlideshow

MIT License
135 stars 78 forks source link

Picture orientation #149

Open nautical-miles opened 5 months ago

nautical-miles commented 5 months ago

Hi, after using this module for quite some time now without any problems I now have an issue with the orientation of some Images. Some of them are upside down or on the side. The pictures from my SLR-Camera are all fine. However those coming from my iPhone show this strange behavour. Importet to my Windows-PC I rotated all of them to the correct orientation. Besides, I did the same with the images from the SLR. From there I moved them to the Linux-PC running the Module. On MagicMirror they have a different orientation than on the Windows-PC. Rotating them upside down on purpose sometimes result in the correct display on MM. However if I restart MM the previously correct pictures are now shown on the side or upside down. The orientation changes every time MagicMirror is restarted. Any ideas on what to do to fix this problem?

Thanks Oliver

KristjanESPERANTO commented 5 months ago

That sounds interesting. Can you provide an image that causes such problems and one that does not?

nautical-miles commented 5 months ago

Testbilder.zip Hi Kristjan, attacht a zipfile with two pictures (hope the upload works). The one with the lake is fine; the other one is not.

nautical-miles commented 5 months ago

While reading through https://github.com/darickc/MMM-BackgroundSlideshow/issues/112#top it came to me that it might be helpfull to add some more information about my setup: I am using a local installation (not docker) on a raspberry pi 3. Somewhere in that issue it is mentioned that a fix is using jimp and "exif data is not taken into account, causing the picture orientation to not be used". Maybe this is already the root of the problem I have.

KristjanESPERANTO commented 5 months ago

The images you provided are working fine on my system. But it's not a Raspberry Pi.

To make sure you're not using a fork, let's see what git remote -v outputs when you are in the modules directory.

It should output something like this:

origin  https://github.com/darickc/MMM-BackgroundSlideshow.git (fetch)
origin  https://github.com/darickc/MMM-BackgroundSlideshow.git (push)

Backup your images if you have saved them in the module directory.

To ensure that you use the latest version of the module, do the following in the modules directory:

git reset --hard
git checkout master
git pull
npm install

Start MagicMirror and check whether the issue still occurs.

nautical-miles commented 5 months ago

Hi Kristjan, sorry for the late reply. Doing git remote -v gave the same result as in your example; so it is not a fork. I also reinstalled the module to make sure it is the latest version and restarted MagicMirror. I'll let you know if it helped to fix this issue.

nautical-miles commented 5 months ago

After a longer test, including some reboots, I have to say that it did not work. The pictures in question still have the wrong orientation.

KristjanESPERANTO commented 5 months ago

As I cannot reproduce your problem on my system, it is difficult for me to find the cause. Perhaps try searching for help in the forum.

nautical-miles commented 4 months ago

At least I have a workaround to fix this problem. After converting the images from jpg to png the orientation was correct. Even after a reboot it stayed this way.