darickc / MMM-BackgroundSlideshow

MIT License
145 stars 84 forks source link

First attempt to add video playback support #81

Closed mw46d closed 4 years ago

mw46d commented 4 years ago

Hello, I don't know, iff you want to add this. But at least, I wanted to let you know, that this seems to be working;-) I decided to use the omxplayer because it gives much smoother playback (even on a RaspPi4) than the HTML tag:-( This setup plays the video behind the MM, so all other modules can write their text/notifications as usual and it's still readable.

l-carado commented 3 years ago

Hi @mw46d, I've a problem with this upgrade, I don't see images anymore, the screen is black The module dosen't find the image file. I found the error in line 363 of your upgrade: mw_image_src = encodeURI(this.imageList[this.imageIndex]);

You use the encodeURI() two times because it's also in line 476: image.src = encodeURI(mw_image_src);

I've resolved removing the encodeURI() in line 363: mw_image_src = this.imageList[this.imageIndex];

but I don't know if you need the encodeURI() for other reasons. Is better if you check it.