search

darickc / MMM-BackgroundSlideshow

MIT License
138 stars 79 forks source link

certain files don't display #95

Open cweinhofer opened 3 years ago

cweinhofer commented 3 years ago

I have been using this module to turn my MagicMirror into a sort of info display / photo frame hybrid -- with a collection of 500+ photos (organized into sub-folders by event) changing randomly every few hours.

Over the course of the past year, though, I've noticed that certain photos are never displayed. I started looking into the cause and believe it has to do with the folder names . It seems like photos in folders with an apostrophe in the name (e.g. Mary's Wedding) don't come up. Could this be true?

It's hard to test definitively because my collection is so large and I'm using a random selection, so I thought I'd see if anyone else has encountered this? My guess is that the apostrophe is interpreted as a single quote and throws the code off somehow.

Any feedback would be appreciated.

cweinhofer commented 3 years ago

I've done some further testing and it seems like even with purely alpha characters (plus spaces), some pictures still don't display. They try, but the screen is just black.

They are all JPG. Is there something in the JPG encoding on particular files that could cause this?

darickc commented 3 years ago

Do you still have this issue with the latest update?

cweinhofer commented 3 years ago

Yes, it seems so.

And I'm starting to go back to my original hypothesis. It seems like apostrophes are the culprit -- but that it also causes problems when they're in the file name and no just the folder name.

Please let me know if there are any sort of tests or logs that would be helpful.