Investigate and potentially remove `next/dist/compiled/edge-runtime` shimming

[dario-piotrowicz]

Intro

The repository current goal is to get a minimal hello-world Next.js api app running using wrangler dev.

At the time of writing this issue (current commit) the hello-world app is still not successfully running, but it should hopefully be close to it.

To get the application to the current state a series of temporary hacks/workaround were introduced, those should be cleaned up and re-implemented in a stable way.

This issue is for the removal of one of such hacks/workarounds.

The hack/workaround

The next/dist/compiled/edge-runtime import is aliased during the worker build: https://github.com/dario-piotrowicz/poc-build-nextjs-app-for-cf-workers/blob/d380bbf8cf8e744d2261751457636b808f13c762/nextjs-worker-builder/src/build/build-worker/index.ts#L67-L71

This is introduced simply to remove the following wrangler dev warnings:

(but not shimming the module doesn't seem to cause the application not to work)

We should investigate the module and in particular answer the following:

• does stubbing the module out can break some Next.js functionality? (what does the module do?) or is it ok to just stub this out to an empty shim? (or a similar solution)
• as I mentioned in my comment it seems like this shim is not present in https://github.com/mhart/nextjs-commerce is there a reason why it might not be necessary there but it is here?
• the module's name suggest that this is something for the edge runtime, which is not used in the hello-world Next.js api app so why is it getting included in the bundle in the first place?

[dario-piotrowicz]

Note: I just saw why Micheal's version didn't need this

it's just because he went a different route and fixed in this way instead (source):

  // No need for edge-runtime sandbox
  build.onResolve({ filter: /\.\/web\/sandbox$/ }, (args) => ({
    path: path.join(import.meta.dirname, './shim-empty.mjs')
  }));