Resolve modules without using `devEnv.pluginContainer.resolveId` - Githubissues

dario-piotrowicz / vite-environment-6.0.0-alpha-experimentations

1 stars 1 forks source link

Resolve modules without using `devEnv.pluginContainer.resolveId` #5

Closed dario-piotrowicz closed 3 days ago

dario-piotrowicz commented 3 months ago

In the workerd environment provider we use devEnv.pluginContainer.resolveId to resolve external dependencies to the correct files in the filesystem: https://github.com/dario-piotrowicz/vite-environment-6.0.0-alpha-experimentations/blob/cab58e9bffbe1b1e944ec2c7119ca062a8e97e38/packages/vite-environment-provider-workerd/src/index.ts#L182

This is not really correct as discussed in this discord thread and this vite environment PR discussion and we should resolve modules in a different manner.

Possible solutions are:

using config.createResolver exposed in v6.0.0-alpha.18 (this should work quite well but we could try not to go with this solution as the Vite team find this hard to maintain and would prefer not to have to actually include it)
- using the import-meta-resolve package

dario-piotrowicz commented 1 month ago

Note: This is (soft) blocked as we'd ideally need to have Remix off of the functions directory to test this (PS: we might find other ways to test this in case we're not comfortable waiting for the Remix changes)