search

dariocravero / padrino-websockets

Agnostic websockets support for Padrino
MIT License
14 stars 9 forks source link

ArgumentError happens when 'on_shutdown' is called #7

Open tunepolo opened 9 years ago

tunepolo commented 9 years ago

By af0c7ee277239cb1f487949de4378250ed17b415 commit, parent 'on_shutdown'(=base-event-manager.rb) invocation is added.

[lib/padrino-websockets/faye/event-manager.rb]

def on_shutdown(event)
  @pinger.cancel if @pinger
  super
end

[lib/padrino-websockets/base-event-manager.rb]

def on_shutdown
  logger.debug "Disconnecting user: #{@user} from channel: #{@channel}."
  @@connections[@channel].delete(@user)
end

Ruby's 'super' passes the same parameters when parameters are omitted, so ArgumentError happens.

janus112 commented 9 years ago

@dariocravero Yes, I dont know why I did catch that one when testing, I must have tested the wrong version, sorry.