search

dariocurr / checkout-called

Checkout the called repository at the same ref it was called
https://github.com/marketplace/actions/checkout-called-repository
MIT License
1 stars 0 forks source link

Support for GitHub Enterprise #3

Closed Plonk42 closed 1 week ago

Plonk42 commented 1 week ago

Hey, thank you for this action!

I was investigating if this could help us facing https://github.com/actions/toolkit/issues/1264, but I think it wouldn't work in our GitHub Enterprise environment.

In particular, I think the input github-server-url should be use there instead of hard-coded https://api.github.com/ at:

https://github.com/dariocurr/checkout-called/blob/5c027406d1f1e55c949e99b72851c44a8859c831/action.yml#L103

dariocurr commented 1 week ago

Great suggestion, thank you!

But I guess the input we should use is github.api_url. Isn't it?

dariocurr commented 1 week ago

Please ensure that it works also in GitHub Enterprise environments. I have no easy way to test it

Plonk42 commented 1 week ago

I had to downgrade the checkout action to the latest version supported on my GHE instance (actions/checkout@v4.1.1 instead of actions/checkout@v4.2.1), which also required to remove the ssh-user input, but apart from this it seems to work great. Thanks for the quick fix!

dariocurr commented 1 week ago

Thank you. I'm glad to help!