search

dariogoetz / keyboard_layout_optimizer

A keyboard layout optimizer supporting multiple layers. Implemented in Rust.
https://dariogoetz.github.io/keyboard_layout_optimizer/
GNU General Public License v3.0
92 stars 18 forks source link

Duplicate short option `-n` #28

Closed Glitchy-Tozier closed 2 years ago

Glitchy-Tozier commented 2 years ago

When using this command cargo build && ./target/release/random_evaluate -h, we see that there's a duplicate short option ("-n"). I suggest un-shortening one of them. Which one would you prefer?

The problem is that -n, --number-of-samples is more important in this crate, but -n, --ngrams is more important everywhere else (it really is the only option everywhere else).

    -n, --ngrams <NGRAMS>
            Path to ngram files [default:
            corpus/deu_mixed_wiki_web_0.6_eng_news_typical_wiki_web_0.4]

    -n, --number-of-samples <NUMBER_OF_SAMPLES>
            Number of samples [default: 1000]
Glitchy-Tozier commented 2 years ago

One possible fix might be to rename "ngrams" to "corpus".