dariogoetz / keyboard_layout_optimizer

A keyboard layout optimizer supporting multiple layers. Implemented in Rust.
https://dariogoetz.github.io/keyboard_layout_optimizer/
GNU General Public License v3.0
90 stars 15 forks source link

Replace short `HashSet`s with `Vec`s #32

Closed Glitchy-Tozier closed 2 years ago

Glitchy-Tozier commented 2 years ago

The main ones:

I base this request off of those benchmarks: https://gist.github.com/daboross/976978d8200caf86e02acb6805961195

  1. I wasn't able to reproduce the Tests using AHashMap, but it still should be slightly faster, especially considering that our Vecs are about 5 times as small as the ones in the tests.
  2. It wouldn't help much in terms of speed, but when moving from FxHashSet to something else, we could straight up us Vecs and thus remove some imports from a few files.