Fixed null pointer issue called by globalPaintBounds being null while in left or right direction mode.

darioielardi / flutter_speed_dial

Flutter plugin to implement a Material Design Speed Dial

https://pub.dev/packages/flutter_speed_dial

MIT License

416 stars 178 forks source link

Fixed null pointer issue called by globalPaintBounds being null while in left or right direction mode. #260

Closed ghost closed 2 years ago

ghost commented 2 years ago

Standard linter refactor (local variables should not be private and child parameters go last).

luca-colazzo commented 2 years ago

LGTM The only question is, if you cared that much about lints and the position of the attributes, then why didn't you use the same template for the condition?

ghost commented 2 years ago

I honestly don't care that much about lints and position of the attributes. The changes was given to me for free. If you are referring to why the globalPaintBounds check is different for the isRight part. It is because i thought it was going to be harder to read if I add the null check twice within the Offset part for the isRight statement.