search

dariopb / ha-gosenseapp

Application that uses the gosense library to discover and publish sensor information to HA via MQTT
39 stars 12 forks source link

Only forward Alarms with flag 0xA2, ignore others #4

Closed tholland15 closed 4 years ago

tholland15 commented 4 years ago

Alarms with flags other than 0xA2 are not well understood nor do they follow the expected format of this repo and therefore should not be sent to MQTT. All open/close & motion on/off alarms in my testing have had the SensorFlag 0xA2

I've never written Go before, if there is a better/cleaner way to do this, please edit.

Fixes #2

shauder commented 4 years ago

Would you be able to kick off docker builds? I tried building some new ones from a fork but the builds fail.

EDIT: Nevermind, built it manually and pushed it up instead of trying to get docker hub to build it.

dariopb commented 4 years ago

Cool, thanks.I have some other changes I'm making and I'll push the docker images (@shauder, let me know is you still need me to create them right now).

shauder commented 4 years ago

I don't need them now thanks! I did create another issue on the other repo with another error I am having with those changes. I reverted those changes and took the changes on this repo and made a new docker image. I am good for now.

dariopb commented 4 years ago

Thanks. I pushed the changes I was making and I didn't consider the "older" configurations. It is fixed with fcc5776 (I validated with both names and string numbers for the config).

shauder commented 4 years ago

Thanks for fixing! I will test this week.