search

darioteixeira / lambdoc

Lambdoc is a library providing support for semantically complex documents in Ocsigen web applications
GNU General Public License v2.0
17 stars 1 forks source link

Improve markdown handling #13

Closed Drup closed 9 years ago

Drup commented 9 years ago

Not completely finished yet, I need to implement Raw and Html.

Probably solves https://github.com/darioteixeira/lambdoc/issues/11

darioteixeira commented 9 years ago

Thanks @drup. I'll merge this. The 3-tuple solution I used for counting nesting level starts to look at bit silly when expanded to a 6-tuple (might be worth switching to an array), but that's a minor issue that can be fixed later...

Drup commented 9 years ago

I agree, and same can be said about the Various `Level constructors.

darioteixeira commented 9 years ago

Just a heads-up: your patch did not update the Writeconv module with support for six nesting levels. This is now fixed in trunk.

Drup commented 9 years ago

Ah! I followed the type errors and assumed it was complete, sorry!

darioteixeira commented 9 years ago

I also almost missed it when compiling under 4.02: the compiler does warn about the missing match cases in Writeconv, but these are easily lost amongst other harmless warnings...