search

dariusbakunas / terraform-provider-truenas

Experimental terraform provider to manage TrueNAS server
MIT License
72 stars 16 forks source link

set share's name just after purpose to fix #11 #12

Closed damoun closed 1 year ago

damoun commented 1 year ago

To fix #11, I set the SMB share name just after the share purpose.

On a share smb resource creation with an ENHANCED_TIMEMACHINE purpose, the name is omitted and so TrueNAS will respond with an error 500. To fix this issue, I had to reorder how you set the CreateShareSMBParams struct. I could not find why but the name is set to nil if we set it after Timemachine. If we set name before Timemachine, name is not omitted anymore.

damoun commented 1 year ago

I don't have the permission to merged it, can you do it please ? Thanks

damoun commented 1 year ago

Could you make a new release tag ?