search

dariusbakunas / terraform-provider-truenas

Experimental terraform provider to manage TrueNAS server
MIT License
72 stars 17 forks source link

Add Group and User resources #7

Open aarontc opened 1 year ago

aarontc commented 1 year ago

(This is my first Go project PR, if it needs any changes please let me know.)

dariusbakunas commented 1 year ago

Looks good so far, but I would like to see some tests for both, fairly straightforward, just follow existing examples, thanks!

lkubb commented 1 year ago

It seems you might have based parts of your implementation on mine (https://github.com/lkubb/terraform-provider-truenas/tree/users-groups), which does contain tests and thus could be a good starting point. I wanted to submit it last year after the PR for the API, but life got in the way sadly and I was not 100% satisfied the way it was.

Otherwise, we/I can also incorporate your improvements into that branch and update the tests accordingly to get this feature over the line.

aarontc commented 1 year ago

It seems you might have based parts of your implementation on mine (https://github.com/lkubb/terraform-provider-truenas/tree/users-groups), which does contain tests and thus could be a good starting point. I wanted to submit it last year after the PR for the API, but life got in the way sadly and I was not 100% satisfied the way it was.

Otherwise, we/I can also incorporate your improvements into that branch and update the tests accordingly to get this feature over the line.

I actually had no idea that someone had started working on this when I decided to add the feature. If you've got something that works, we can definitely close my PR. Real life has gotten in the way on my end as well. I did start working on tests a while back, and I found a couple of issues already, so this PR isn't mergeable as-is.

Either way, I'll get back to this eventually... I just can't commit to when that will happen. :(

mircea-pavel-anton commented 11 months ago

@aarontc sorry for the ping, but are there any updates on this? I'm also interested in this feature 😄