darkain / pudl

PHP Universal Database Library - connects to and generates queries for SQL Servers
BSD 2-Clause "Simplified" License
28 stars 5 forks source link

Make setting sql_mode optional #17

Closed darkain closed 2 years ago

darkain commented 4 years ago

There is a reported bug that setting sql_mode through ProxySQL causes an invalid syntax error.

Also, applications may want a particular SQL mode separate from the PUDL default.

Make this a configurable value, with an optional NULL/false/0/'' value to not call SET sql_mode at all.

Default value will be [true], which uses PUDL's current sql_mode string.

darkain commented 2 years ago

Fixed in: https://github.com/darkain/pudl/commit/a7cc72bafa94e01b4244318609563b6d327cb7ed