search

darkain / pudl

PHP Universal Database Library - connects to and generates queries for SQL Servers
BSD 2-Clause "Simplified" License
28 stars 5 forks source link

standardize "connected" variable #22

Closed darkain closed 2 years ago

darkain commented 3 years ago

adding "connected" to pudl/mysqli broke galera. the variable is used for similar, but not quite the same usage. moving the galera usage upstream in the codebase and standardizing on its meaning, merging the two together, would be highly beneficial.

galera currently doesnt track disconnects, so it'll still show the server it is connected to, even after disconnect.

pudl currently only tracks true/false if actively connected, not what server is actively connected to. considering that mysqli and other implementations may get multi-master support, this is something important to have to keep track which node is actively connected.

darkain commented 3 years ago

Started on it here: https://github.com/darkain/pudl/commit/d0403f99979b6745bcf816352557fb238dba3c0d

darkain commented 2 years ago

Completed in: https://github.com/darkain/pudl/commit/2353ab8eefea115aaf5273b15b8a3e72ad948c13