search

darkain / pudl

PHP Universal Database Library - connects to and generates queries for SQL Servers
BSD 2-Clause "Simplified" License
28 stars 5 forks source link

Check to see if pudl::inSet() and pudl::notInSet() are redundant #27

Closed darkain closed 2 years ago

darkain commented 2 years ago

inSet: https://github.com/darkain/pudl/blob/9aff97a205fbb389a21520c254d1074393b84663/test/inset.inc.php#L15 https://github.com/darkain/pudl/blob/9aff97a205fbb389a21520c254d1074393b84663/test/clause.inc.php#L140

notInSet: https://github.com/darkain/pudl/blob/9aff97a205fbb389a21520c254d1074393b84663/test/inset.inc.php#L21 https://github.com/darkain/pudl/blob/9aff97a205fbb389a21520c254d1074393b84663/test/clause.inc.php#L357

darkain commented 2 years ago

Fixed in: https://github.com/darkain/pudl/commit/1d0542850d503afa0c57d574525e3895ed83fbe5