darkain / pudl

PHP Universal Database Library - connects to and generates queries for SQL Servers
BSD 2-Clause "Simplified" License
28 stars 5 forks source link

"escape" needs to use "connection" not "connected" #32

Closed darkain closed 2 years ago

darkain commented 2 years ago

There are internal SQL queries generated and executed before we finalize the "connected" status. Because of this, the "escape" method should rely on a connection at all, not specifically our own internal "connected" status. This breaks things like Galera's wsrep_local_state.

darkain commented 2 years ago

Fixed in: https://github.com/darkain/pudl/commit/bd53ec05480dfcf15ac533a6aa6fe534439ed058