darkautism / PS3TrophyIsGood

Best ps3 trophy editor ever
MIT License
43 stars 15 forks source link

Unhandled Exception #6

Closed Demask70 closed 3 years ago

Demask70 commented 3 years ago

Hi, I'm experimenting with your tool and discovered the following:

1) If you unlock trophies for a certain game using two different consoles (A & B, to be clearer), when you open in PS3TrophyIsGood the trophy folder downloaded from console "A", you see as "LOCKED" and apparently "NOT SYNCED" all the trophies you unlocked and synced from console "B". This happens even if all the trophies are correctly synced to PSN (so does each single trophy stores the _consoleid info?)

2) If you click on "Instant Platinum", you get an Unhandled Exception

3) if you try to correct the timestamp of a specific trophy, you get the same "Unhandled Exception" unless you input a "recent" date: you can't input a date older than 15 days from today

I think you are aware of this "limit" (or "check") because, in the Unhandled Exception window, I can read a chinese message I roughly translated with "Already synced with PSN, try a later date"

Why does this happen? Is there a way to see as "GET" and "SYNCED" every trophy unlocked with two or more consoles?

Last... Excuse me... Is there a way to download the *.exe of the version 1.3.7? I can't, at the moment, compile the code.

Thank you in advance for your answer and for your great job!

darkautism commented 3 years ago

1 This seems like a cool bug. I do not have a PS3 console a long time ago so I can't help anymore.

2&3. It seems the trophy parser is detected your trophy is already synced https://github.com/darkautism/TROPHYParser/blob/53540c1ec605790f390b4ea92a540b673038f098/TROPHYParser/TROPTRNS.cs#L183

If You wanna remove this check, just remove this line, or if statement to prevent Exception. But I do not sure sync to PSN causes a ban if the user already synced. I didn't know the PSN server-side has double synced detection.

https://github.com/darkautism/PS3TrophyIsGood/actions/runs/580453998

I add auto-build in this project. You can download the newest version in artifacts. image

jhonathanc commented 3 years ago

I think the #7 partially fixed this issue. @Demask70, could you please try v1.3.7 and check? (this version also contains the fix to avoid TROPTRNS.DAT corruption - #11): https://github.com/jhonathanc/PS3TrophyIsGood/releases/download/1.3.7/PS3TrophyIsGood.zip

Now trophies synchronized on another console are being showed as synchronized. I still didn't check the issue with date/time, but It's the next thing I will take a look.

@darkautism I really liked this "auto-build". Is it difficult to configure on github?

darkautism commented 3 years ago

@jhonathanc It is easy to deploy an auto-build, just upload a configure file in your project. https://github.com/darkautism/PS3TrophyIsGood/blob/master/.github/workflows/dotnet-desktop.yml