darkerz7 / CSGO-Plugins

My Plugins
47 stars 34 forks source link

Fix clan tag module #47

Closed sTc2201 closed 2 years ago

sTc2201 commented 2 years ago

Changing the method of how the clan tag is retrieved when changed through settings menu. There is an edge case where OnClientSettingsChanged is "falsely" called through setinfo and thus could potentially store the clan tag of an actual item name. So when the item is dropped/removed etc. it would reset to the wrong clan tag.

A way to reproduce that bug is by using GFL's transparency models and the config provided to toggle the transparency levels https://gflclan.com/topic/44920-transparency-player-models-updated-20220221/?do=findComment&comment=348175

Fix found & taken from Kxnrl entWatch fork so credits go to him :) https://github.com/Kxnrl/entWatch/blob/9e6ba5826173c4f3379216aaca55b283dd845621/entWatch.sp#L672