search

darkf / darkfo

DarkFO, a post-nuclear RPG remake (of Fallout 2)
Apache License 2.0
135 stars 12 forks source link

Test/fix [Done] dialogue #118

Open darkf opened 6 years ago

darkf commented 6 years ago

In scripting.ts, we have:

$("#dialogue").append("&nbsp;&nbsp;\"" + msg + "\"<br><a href=\"javascript:dialogueEnd()\">[Done]</a><br>")

But #dialogue no longer exists, it was replaced. Earlier we have for normal replies:

            //$("#dialogue").append("&nbsp;&nbsp;\"" + msg + "\"<br>")
            uiSetDialogueReply(msg)

So we replaced it and the UI module now handles it, but it looks like [Done] options were never ported over.

It was added in 3fe7d5d27a29596903213d075aab2be56a11ee4b.

jQuery was obscuring the selector failing.

I can't think off the top of my head what a good map to test this would be.

darkf commented 6 years ago

It looks like there's some other archaic cruft in there, like endBarter (unused).