darkf / darkfo

DarkFO, a post-nuclear RPG remake (of Fallout 2)
Apache License 2.0
135 stars 12 forks source link

Stats calculated wrong for ACTemVil #124

Closed darkf closed 6 years ago

darkf commented 6 years ago

Max HP is pinned at load time when it's loaded from his PRO, but Max HP is later affected by bonuses from END and STR. As a result, his HP is less than half his Max HP and the fight ends instantly.

I'm not sure if we should ignore bonuses on NPCs and just use the default PRO values (needs testing), or if we should set the HP to max after we calculate the actual post-bonus Max HP.

darkf commented 6 years ago

Apparently, set_critter_stat does not actually work on NPCs, and their stats seem to be fixed to their protos. As such, Dumar has 40 HP (from his proto), and you cannot increase his END with a script to boost it.

For now I've added a flag disabling stat bonuses on stat sets derived from PROs. I'm not sure if this is entirely correct, but it will serve fine for now. (If we need it for drugs later, we can approach it differently.)