darkfeline / cantata

Automatically exported from code.google.com/p/cantata
GNU General Public License v3.0
0 stars 0 forks source link

Background image will not apply or save in Play Queue tab in Interface Settings #525

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Which version of Cantata?

1.4.0

Which build? KDE, Qt4, Qt5, Windows, Ubuntu, Mac?

KDE 4.14.0 on Arch Linux with the following switches:
-DCMAKE_INSTALL_PREFIX=`kde4-config --prefix` \
-DCMAKE_BUILD_TYPE=Release \
-DENABLE_HTTP_STREAM_PLAYBACK=ON \
-DENABLE_KDE=ON \
-DCANTATA_TRANSLATIONS=en_US \
-DENABLE_ONLINE_SERVICES=OFF \
-DENABLE_KWALLET=OFF \
-DUSE_SYSTEM_MENU_ICON=OFF \
-DENABLE_DEVICES_SUPPORT=OFF

What steps will reproduce the problem?

1. Open Configure Cantata from menu.
2. Navigate to Interface Settings and select Play Queue tab.
3. Set Background Image to Current Album Cover or Custom Image.
4. Click OK. Setting does not take effect and defaults back to None. Click 
Apply and nothing happens.

What is the expected output? What do you see instead?

The expected output is for the setting to take effect and the background image 
appears. Instead no image appears and when I check settings it always defaults 
back to none.

Please provide any additional information below.

I tested this on a QT5 build and the background image setting works as expected.

Original issue reported on code.google.com by hbdee.a...@gmail.com on 21 Aug 2014 at 2:17

GoogleCodeExporter commented 9 years ago
Just tried, and indeed the view is not update immediately - but is when the 
album changes. (If set to current cover). I have fixed this in branches/1.4 and 
trunk

However, the setting is (for me) saved. As in if it is set to none, I change it 
to current cover in the pref dialog, press OK. When I go back into the pref 
dialog it is still set to 'current cover'

If possible, can you please try branches/1.4 from trunk?

svn checkout http://cantata.googlecode.com/svn/branches/1.4 cantata-1.4

Original comment by craig.p....@gmail.com on 21 Aug 2014 at 5:14

GoogleCodeExporter commented 9 years ago
Also, what is the value of playQueueBackground in ~/.kde/share/config/cantatarc

Original comment by craig.p....@gmail.com on 21 Aug 2014 at 6:38

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Compiled branches/1.4 from trunk and I still have the same problem. The weird 
thing is 'playQueueBackground=true' and 
'playQueueBackgroundFile=/home/foo/foo.png' are the values in cantatarc.

Original comment by hbdee.a...@gmail.com on 22 Aug 2014 at 10:34

GoogleCodeExporter commented 9 years ago
Ah, that's the issue. The config item used to be a bool (true/false), and was 
changed to an integer. However, it looks like the KDE config code does not like 
saving an integer where it was a bool. I'll modifiy the code to fix this.

For now, just edit cantatarc and change playQueueBackground=1 (whilst cantata 
is not running). Any subsequent updates in Cantata will then work.

Original comment by craig.p....@gmail.com on 22 Aug 2014 at 11:11

GoogleCodeExporter commented 9 years ago
Awesome, thanks a lot. Keep up the good work :)

Original comment by hbdee.a...@gmail.com on 22 Aug 2014 at 11:15

GoogleCodeExporter commented 9 years ago
Implemented for 1.4.1 now

Original comment by craig.p....@gmail.com on 22 Aug 2014 at 3:58