darkfeline / cantata

Automatically exported from code.google.com/p/cantata
GNU General Public License v3.0
0 stars 0 forks source link

sticker number range #555

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Which version of Cantata?
SVN latest

Which build? KDE, Qt4, Qt5, Windows, Ubuntu, Mac?
arch linux 

Hi Craig

How are you?

im loving the sticker integration with svn cantata.
i have a Q though. other mpd apps use a 1-5 range that makes to me more sense. 
would you consider (even as an option) to set rating range from 1-5 instead of 
1-10 as currently implemented (unless im wrong?)

thx alot

Z

Original issue reported on code.google.com by ikl...@gmail.com on 4 Oct 2014 at 3:42

GoogleCodeExporter commented 9 years ago
Why? What other MPD apps? Do they store fractional ratings? e.g. 1.5? The 
reason Cantata uses '1-10' is so that it can store 1 star = sticker value of 2 
and 1/2 star = sticker value 1

I did not want to use 1/2 star = sticker value 0.5 as I didnt wnat to deal with 
locale issues where some locale's use 0,5

Original comment by craig.p....@gmail.com on 4 Oct 2014 at 4:49

GoogleCodeExporter commented 9 years ago
Ok Craig, fair enough :)

thx

PS- other clients like gmpc and clerk

best

z

Original comment by ikl...@gmail.com on 4 Oct 2014 at 5:06

GoogleCodeExporter commented 9 years ago
gmpc does not use ratings - I think it used to, but was then removed. clerk 
does not seem to use ratings in MPD's sticker db - or at least not from what I 
could see of the docs.

In Cantata's the UI ratings are still 1-5 It's just the value stored in the DB 
is 1-10 This is /sort of/ consistent with other apps - where FMPS rating tags 
are stored as fractions of 1 (e.g. 2 stars = 0.4)

So, do any other MPD apps store ratings in MPD's sticker DB? If not, then there 
is no issue.

I'll happily change things - as 1.5 has not yet been released - I just need to 
know a valid reason as to why.

Original comment by craig.p....@gmail.com on 4 Oct 2014 at 5:23

GoogleCodeExporter commented 9 years ago
Hi... clerk dev here. 
You are right, clerk never used stickers, but my own system was a nightmare to 
use, so I changed it today.
I will simply adopt to your 10 stars system, so ratings are consistent across 
clients. 

Original comment by rasmus.s...@gmail.com on 4 Oct 2014 at 5:51

GoogleCodeExporter commented 9 years ago
OK, great :-) As I said, the rating support is not in any released version - so 
I had no issue with changing it, just needed a good reason :-)

Just to be 100% sure... Cantata is using a sticker name of (without quotes) 
'rating' and then values 1..10 In the UI each rating step is 1/2 a star. Does 
this match the clerk usage?

Original comment by craig.p....@gmail.com on 4 Oct 2014 at 6:03

GoogleCodeExporter commented 9 years ago
yes, thats exactly how i do it... 
i was thinking about album ratings too, but this would have to be done in each 
track of an album... a bit crap, what do you think?

Original comment by rasmus.s...@gmail.com on 4 Oct 2014 at 6:06

GoogleCodeExporter commented 9 years ago
To be honest, I'm not sure if I see the point. But then I would not use ratings 
anyway :-)

In Cantata not sure where I would show the album-rating, it would make the UI a 
bit too cluttered. Plus, do any other (popular) music apps store an album 
rating?

From my perspective (as non ratings user), I'd assume the album rating is the 
average of the songs ratings...

Original comment by craig.p....@gmail.com on 4 Oct 2014 at 6:30

GoogleCodeExporter commented 9 years ago
..anyway, guess this bug is no longer valid.

Original comment by craig.p....@gmail.com on 4 Oct 2014 at 7:16

GoogleCodeExporter commented 9 years ago
I talked to Dave (gmpc dev) and he is willing to re-add stickers too. with a 
client de-facto standard, maybe cirrus can be pushed a bit to further implement 
stickers, like originally planned (original draft was meant to append values to 
different types like album, artists, tracks)

Original comment by rasmus.s...@gmail.com on 4 Oct 2014 at 7:20

GoogleCodeExporter commented 9 years ago
and yes... bug is fixed i would say

Original comment by rasmus.s...@gmail.com on 4 Oct 2014 at 7:20

GoogleCodeExporter commented 9 years ago
What would be good is to be able to query MPD by stating 'list tracks with 
sticker name=$NAME and value=$VALUE' Currently you can only list tracks with 
'sticker=$NAME' you then need to parse all the values.

Original comment by craig.p....@gmail.com on 4 Oct 2014 at 8:50