search

darkfeline / cantata

Automatically exported from code.google.com/p/cantata
GNU General Public License v3.0
0 stars 0 forks source link

Can't save ratings when read from multiple files #636

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Which version of Cantata?
trunk

Many of my tracks have FMPS_Rating tags, and it's great that Cantata can read 
them from the files, even multiple files at once.  But when you read them from 
multiple files, you can't save the ratings to the database, because the Save 
button is grayed out.  The only way to keep the ratings is to do it 
track-by-track.  Since the Save button can't be clicked, it's unclear whether 
the ratings have actually been saved until you look at the track's info again 
and see that it still has no rating.

I wonder if the ratings-reading should be separate from the Edit Track 
Information dialog.  When I read the rating from a track's tags, I don't want 
to also rewrite the file's tags when I click the Save button.  I don't know if 
Cantata actually rewrites the file if the other tags are unchanged, but it kind 
of implies that it does.  At the least, this would be an issue for backup and 
sync software, because it would cause the mtime to change, causing the file to 
be backed up again, or at least rehashed, which causes CPU use and disk I/O.

Maybe there could just be an entry under the track's Set Rating context menu to 
"Read ratings from file", which would read the rating from the file and save it 
to the database.

Thanks!

Original issue reported on code.google.com by alphadel...@gmail.com on 25 Feb 2015 at 6:02

GoogleCodeExporter commented 9 years ago 
Hmmmm... I will have to check this - currently I dont actually use ratings!

Only tags that have been changed should be written to the file. Likewise, 
ratings are only saved when 'Save' is selected. 'Save' implies that change will 
be saved.

Ratings are part of 'Track Information' - therefore this dialog is the correct 
place for this, and is consistent with other media players.

Original comment by craig.p....@gmail.com on 25 Feb 2015 at 6:09

GoogleCodeExporter commented 9 years ago 
Implemented in trunk and branches/1,5 now.

Original comment by craig.p....@gmail.com on 26 Feb 2015 at 8:08