search

darkforest-eth / plugins

A showcase of Dark Forest plugins from the community!
https://plugins.zkga.me
GNU General Public License v3.0
123 stars 136 forks source link

SimultaneousAttack-port v6R5 #222

Open Stx69 opened 2 years ago

Stx69 commented 2 years ago

Simple port to v5R6

cristobal commented 2 years ago

@ichub this is a duplicate of @davidryan59 PR #190, i think we should rather stick with 190. However a difference in the PR's is the change done in the df.move:

While @Stx69 on this PR rewrote the following move:

df.move(attacker.locationId, target.locationId, Math.floor(attacker.energy * 0.5), 0);

to:

df.move(attacker.locationId, target.locationId, Math.floor(attacker.energy * 0.5), 0, null, false);

And @davidryan59 PR to:

df.move(attacker.locationId, target.locationId, Math.floor(attacker.energy * energyPercent * 0.01), 0);

Still the PR from @davidryan59 does a bit more, and i think we should rather approve that PR first since it also first in the line.

ichub commented 2 years ago

@ichub this is a duplicate of @davidryan59 PR https://github.com/darkforest-eth/plugins/pull/190, i think we should rather stick with 190.

OK