search

darklang / dark

Darklang main repo, including language, backend, and infra
https://darklang.com
Other
1.68k stars 91 forks source link

Can't delete function parameters when a variable of the same name is declared #2542

Closed pbiggar closed 1 year ago

pbiggar commented 4 years ago

In the gif, the toEmail parameter is not used. However, another variable is declared called toEmail, and this prevents us from deleting the toEmail parameter. It seems we're applying a rather simplisitic rule to prevent deleting, and we should take scoping rules into account.

2020-02-25_10 08 31

dstrelau commented 4 years ago

@pbiggar I think this has the wrong GIF attached.

pbiggar commented 4 years ago

@pbiggar I think this has the wrong GIF attached.

Fixed, thanks!

pbiggar commented 2 years ago

We're going to redo this to use fluid, we should check this works after.

pbiggar commented 1 year ago

Not applicable in darklang-next.