darklang / rescript-tea

The Elm Architecture for Rescript
Other
119 stars 9 forks source link

Remove Html module and make Html2 the default #13

Closed pbiggar closed 2 years ago

pbiggar commented 2 years ago

The flat name space is less idiomatic than the nested modules in HTML2

OceanOak commented 2 years ago

Html module is only used inside test files and tea_html2.res

This is where it is used in tea_html2.res. Should I move them from tea_html.res to tea_html2.res

and remove tea_html.res file?

let on = Tea_html.on

  let onWithOptions = Tea_html.onWithOptions

  let defaultOptions = Tea_html.defaultOptions

  let targetValue = Tea_html.targetValue

  let targetChecked = Tea_html.targetChecked

  let keyCode = Tea_html.keyCode
pbiggar commented 2 years ago

Yes, exactly!

pbiggar commented 2 years ago

Fixed in #17