darklang / rescript-tea

The Elm Architecture for Rescript
Other
119 stars 9 forks source link

Convert snake_case to camelCase in all internal names #27

Closed OceanOak closed 2 years ago

OceanOak commented 2 years ago

tea_app.res render_events ->renderEvents

tea_debug.res debug_msg -> debugMsg

tea_http.res response_status -> responseStatus

tea_promise.res err_to_string -> errToString

tea_task.res testing_deop -> testingDeop

vdom.res new_msg -> newMsg new_smsg -> newSmsg

The ones in the web files were not changed. Hopefully we will not use them anymore after completing issue #4.

OceanOak commented 2 years ago

I don't think so. I verified the files the only one we removed since the begining is tea_html when we switched from tea_html to tea_html2.

pbiggar commented 2 years ago

That's weird. I get this diff:

diff --git a/lib/js/src/tea_task.js b/lib/js/src/tea_task.js
index 1f66b0e..3829383 100644
--- a/lib/js/src/tea_task.js
+++ b/lib/js/src/tea_task.js
@@ -319,7 +319,7 @@ function sequence(x) {
   }
 }

-var testing_deop = {
+var testingDeop = {
   contents: true
 };

@@ -367,7 +367,7 @@ function testing(param) {
         _0: 86
       }, f);
   var r = function (param) {
-    if (testing_deop.contents) {
+    if (testingDeop.contents) {
       return /* Task */{
               _0: (function (cb) {
                   return Curry._1(cb, {
@@ -754,6 +754,6 @@ exports.map4 = map4;
 exports.map5 = map5;
 exports.map6 = map6;
 exports.sequence = sequence;
-exports.testing_deop = testing_deop;
+exports.testingDeop = testingDeop;
 exports.testing = testing;
 /* No side effect */
OceanOak commented 2 years ago

I did change testing_deop variable to camlCase in the tea_task.res file. is that causing a problem?

pbiggar commented 2 years ago

I did change testing_deop variable to camlCase in the tea_task.res file. is that causing a problem?

Not a problem, per se. But if you change the name, the name also changes in the JS. So it seems odd that the JS change isn't in the PR.

OceanOak commented 2 years ago

Tried to rerun npm run-script build and it generated the js file with the changes .