search

darklang / tablecloth

A standard library with the same API in F#, Rescript and OCaml
https://www.tablecloth.dev
MIT License
512 stars 45 forks source link

Error when compiling #46

Closed mrkaspa closed 5 years ago

mrkaspa commented 5 years ago

I got this error after installing and compiliing with the lastest bucklescript

  Warning number 3
  /home/liftit/code/ml/redemo/node_modules/tablecloth-bucklescript/src/tablecloth.ml 797:54-63

  795 ┆ let regex s : Js.Re.t = Js.Re.fromStringWithFlags ~flags:"g" s
  796 ┆
  797 ┆ let contains ~(re : Js.Re.t) (s : string) : bool = Js.Re.test s re
  798 ┆
  799 ┆ let replace ~(re : Js.Re.t) ~(repl : string) (str : string) =

  deprecated: Js.Re.test
Please use Js.Re.test_ instead

  Warning number 3
  /home/liftit/code/ml/redemo/node_modules/tablecloth-bucklescript/src/tablecloth.ml 804:5-14

  802 │
  803 │   let matches ~(re : Js.Re.t) (s : string) : Js.Re.result option =
  804 │     Js.Re.exec s re
  805 │ end

Looks like the definitions of these functions changed

pbiggar commented 5 years ago

Thanks for the report! This should be fixed in 0.0.6 which I released today.