search

darklinkpower / Harmony

Theme for Playnite Desktop Mode.
MIT License
59 stars 13 forks source link

Blur background and darken background affecting game background #25

Open TheTabbingman opened 1 year ago

TheTabbingman commented 1 year ago

Bug Description

The Blur background and darken background in the general appearance settings is affecting the game background aswell as the window background. In the past it only affected the window's background. And these settings are greyed out until you enable the window background. So I don't think they are supposed to be affecting the game background.

To Reproduce

No response

Extensions log

No response

Screenshots

No response

darklinkpower commented 1 year ago

Hi, I'm having trouble understanding what the issue is. These settings affect the game background image when enabled:

image

Can you elaborate what the issue is with screenshots?

TheTabbingman commented 1 year ago

They affect the game background and I don't think they should. They didn't in the past. I want to be able to have a really blurred image as the window background and a not blurred image as the game background.

darklinkpower commented 1 year ago

Can you elaborate what the issue is with screenshots?

TheTabbingman commented 1 year ago

These Settings affecting both the game background in red and the windows background in blue Playnite 10_19_2023 11_31_58 AM Playnite 10_19_2023 11_31_50 AM These settings aren't even available unless you enable the windows background so it doesn't really make sense for it to affect the game background as well

darklinkpower commented 1 year ago

That's not correct, these settings only affect the game window background, which is the blue one. The red one should be unaffected but I just checked and the issue is from the BackgroundChanger extension, which for some reason is blurring its background. I don't know if this is theme related or not since it doesn't do anything to enforce blur but I'll look into it.

TheTabbingman commented 1 year ago

Thank you, disabling the BackgroundChanger extension does fix it.

darklinkpower commented 1 year ago

I looked into the extension code to see how it worked and I'm afraid that this is something that needs to be fixed in the extension itself, ideally with separate options to enable these settings. Right now it is forcefully copying the settings used by the window background image with no way to separate them.