This is a screenshot with this fix in place. The checkmark is now visible even when mouse is hovered over the menu item because the checkmark color gets inverted just like the text does so that it is black on white instead of white on white.
This is how it looks in Helium right now:
This is how it looks with my change:
Ignore the fact that my screenshot shows the menu item highlighting taking the full width of the menu item. That is simply because I have forked Helium and made some other style changes. But I thought the change in this PR about making sure the checkmark is visible might be something you would want to take because it feels like a bug and less so a subjective styling choice.
This is a screenshot with this fix in place. The checkmark is now visible even when mouse is hovered over the menu item because the checkmark color gets inverted just like the text does so that it is black on white instead of white on white.
This is how it looks in Helium right now:
This is how it looks with my change:
Ignore the fact that my screenshot shows the menu item highlighting taking the full width of the menu item. That is simply because I have forked Helium and made some other style changes. But I thought the change in this PR about making sure the checkmark is visible might be something you would want to take because it feels like a bug and less so a subjective styling choice.