darklinkpower / PlayniteExtensionsCollection

Collection of extensions made for Playnite.
MIT License
298 stars 28 forks source link

[Steam Wishlist Discount Notifier] Incorrect price in INR if price is 4+ digits long #315

Open sukarn-m opened 2 years ago

sukarn-m commented 2 years ago

Extension name

Steam Wishlist Discount Notifier

Bug Description

If the price in INR has 4+ digits, an incorrect price is shown in the notification. If the price is 3 digits long, the correct price is shown.

The extension may (or may not) be considering the comma to be the same as a decimal is in some other currencies.

To Reproduce

No response

Logs

There seems to be nothing relevant in playnite.log apart from:

14-09 01:26:28.160|INFO |ExtensionFactory:Loaded plugin: Steam Wishlist Discount Notifier, version 1.13

The only output in extensions.log is:

14-09 01:02:47.938|DEBUG|SteamWishlistDiscountNotifier#SteamWishlistDiscountNotifier:Started checking for wishlist. Status: Ok, steamId: [redactedID]
14-09 01:02:49.107|DEBUG|SteamWishlistDiscountNotifier#Downloader:Created service provider with IHttpClient factory
14-09 01:02:49.115|DEBUG|SteamWishlistDiscountNotifier#Downloader:Downloading string from https://store.steampowered.com/wishlist/profiles/[redactedID]/wishlistdata/?p=0 with method GET
14-09 01:02:50.032|DEBUG|SteamWishlistDiscountNotifier#Downloader:Downloading string from https://store.steampowered.com/wishlist/profiles/[redactedID]/wishlistdata/?p=1 with method GET
14-09 01:02:50.370|DEBUG|SteamWishlistDiscountNotifier#SteamWishlistDiscountNotifier:Wishlist check obtained 5 items, False
14-09 01:02:51.039|DEBUG|SteamWishlistDiscountNotifier#SteamWishlistDiscountNotifier:Finished checking for wishlist
14-09 01:03:29.124|DEBUG|SteamWishlistDiscountNotifier#ProcessStarter:Opening URL: steam://openurl/https://store.steampowered.com/app/1244460/

Screenshots

Discount as per Steam:

image

Discount as per extension notification:

image

sukarn-m commented 1 year ago

Adding one more screenshot for an example:

image