search

darklinkpower / PlayniteExtensionsCollection

Collection of extensions made for Playnite.
MIT License
281 stars 28 forks source link

[Xbox Metadata] Merge plugins #530

Closed Jeshibu closed 2 months ago

Jeshibu commented 2 months ago

Extension name

Xbox Metadata

Feature Description

Hey, I see you've released an Xbox Metadata plugin - I've released one previously, and there's no hard feelings here, just that here's now two extensions named Xbox Metadata, which is confusing for users. I suggest we remove one, and it's fine if it's yours that remains.

I haven't had a chance to compare the two, in practice, but looking at the code, it looks like we could add the Xbox 360 system search/results from my repo. Something I hadn't been able to fix about mine was that the game search always lasted about 10 seconds, which you might have solved. Either way a merger is probably best, whether as a PR to my repo or yours.

Screenshots

No response

darklinkpower commented 2 months ago

Hi, I'm really sorry, I didn't know there was a plugin for Xbox. I totally missed it 😣😣😣 I apologize, I'm unable right now but I'll be removing it asap, likely in the afternoon.

darklinkpower commented 2 months ago

PR to delete it opened, I apologize if this caused any discomfort https://github.com/JosefNemec/PlayniteAddonDatabase/pull/345

Jeshibu commented 2 months ago

No worries! Please don't delete it from this repo yet, you've got at least one search method I hadn't seen yet.

darklinkpower commented 2 months ago

No worries, I plan to keep it here for personal use only.