[Library Exporter Advanced] List separator setting does nothing

Fredrik95 commented 2 weeks ago

Extension name

Library Exporter Advanced

Bug Description

When exporting, changing the "Lists separator:"-option from a comma to anything else does nothing. The CSV is still exported with comma-separators regardless of whatever you change the setting to.

To Reproduce

No response

Logs

extensions.log playnite.log

Screenshots

No response

darklinkpower commented 2 weeks ago

I can't reproduce it. Can you record a video of the process you are doing? also are you sure you are opening the correct file and not a previous one?

Fredrik95 commented 2 weeks ago

I fixed it myself.

https://github.com/darklinkpower/PlayniteExtensionsCollection/blob/master/source/Generic/LibraryExporter/ViewModels/LibraryExporterViewModel.cs

Line 46: var csv = CsvWriter.WriteToText(columnNames.ToArray(), rows, ',');

The last argument is the character used to separate values in the CSV. I changed it to what I needed to delimit the values.

Though now when I see your screenshots maybe we're talking about different things and the "lists separator" option is not meant to change which character delimits the CSV itself, but only when a export option includes multiple things...

It's just that when the character is a comma, and the game name includes a comma, it's difficult to extract the data.

So maybe this isn't a bug report but a feature request. :D

darklinkpower / PlayniteExtensionsCollection