darklinkpower / PlayniteExtensionsCollection

Collection of extensions made for Playnite.
MIT License
332 stars 30 forks source link

[Steam Screenshots] Expose Full resolution images binding for Fullscreen Theme #586

Closed saVantCZ closed 1 week ago

saVantCZ commented 1 week ago

Extension name

Steam Screenshots

Feature Description

Possibility to view full resolution images in ListView for fullscreen themes, plugin only expose thumbnails.

Screenshots

No response

darklinkpower commented 1 week ago

Done in https://github.com/darklinkpower/PlayniteExtensionsCollection/commit/211ba47da5c9de863163f92bc0c3788a3abf82fd

Here's a test build:

SteamScreenshots_8e77fe31-5e62-41e2-8fa2-64844cfd5b6b_1_8.zip

Rename zip extension to pext to install. Property exposed as ScreenshotsFullBitmapImages.


Using the occasion, would you be interested in trying testing a new plugin integration? It's to add a web view to Playnite. It worked fine on my end but not sure if it's good to go or something is missing.

WebExplorer_181ddd05-2168-4162-a116-b9c2a20c652c_1_0.zip

Playnite DesktopApp_egh0nZAKto Playnite FullscreenApp_Jh40DVB3z3

Here's a tutorial if you are interested: https://github.com/darklinkpower/PlayniteExtensionsCollection/wiki/Web-Explorer#integration-of-custom-controls-in-custom-themes

saVantCZ commented 1 week ago

Wow this is amazing, will definitely try on my fullscreen theme.

Thanks for fast response, will test steam screenshots as soon as i get to my PC

darklinkpower commented 1 week ago

I got this email but the actual message is not here anymore. Is it still an issue?

image

saVantCZ commented 1 week ago

My mistake, i was testing it on my portable instance without updated extension instead of my main build.

All works good, just noticed that thumbnail and fullres are not in sync. I am using listview with alternations to show 1st, 2nd and 3rd screenshot thumbnails and when focused on these, another listview became visible with same alternations 1 to 3, but shows different images. Even after clearing screenshots cache and its quite random, some games are in sync with both thumbnails and full, some are scrambled.

But i fixed this by using itemsource from one listview in second one and render fullres images smaller in thumb view.

darklinkpower commented 1 week ago

The randomness issue should be fixed with https://github.com/darklinkpower/PlayniteExtensionsCollection/commit/ac61740cb9c8c1ee77360518edfca324dee8fdd4. However, in my opinion, if you're going to display the high-resolution images anyway, it makes more sense to skip the low-resolution ones entirely. Since all the high-resolution images are being loaded, loading both types simultaneously will only slow things down.

saVantCZ commented 1 week ago

Should be fine once cache is created. But I will rewrite code anyway if randomness is fixed, thanks

darklinkpower commented 1 week ago

Closing as completed.