darklinkpower / Stardust

Theme inspired by GOG Galaxy 2.0 for Playnite Desktop Mode.
MIT License
63 stars 7 forks source link

[Feature Request] Option to have rounded corners #15

Closed ferrazpedro closed 2 years ago

ferrazpedro commented 2 years ago

Feature Description

Hey! Would it be possible to have a ThemeModifier option to give the theme windows rounded corners? Thanks in advance!

Screenshots

No response

darklinkpower commented 2 years ago

Aesthetically personally I don't like rounded corners for the theme, although it should be technically possible to add. But what would be the purpose of this? I don't think it is something that adds something to the theme considering it's not something you see when the window is maximized.

elkhaligy commented 2 years ago

It is so easy actually to edit the corners radius of the main window in MainWindowStyle.xaml line 12

darklinkpower commented 2 years ago

It is so easy actually to edit the corners radius of the main window in MainWindowStyle.xaml line 12

It's not that simple. You also need to modify other values to make sure resizing works properly in all the area in the rounded corners and that buttons can be used without issues no matter the sidebar position or if it's disabled

elkhaligy commented 2 years ago

It is so easy actually to edit the corners radius of the main window in MainWindowStyle.xaml line 12

It's not that simple. You also need to modify other values to make sure resizing works properly in all the area in the rounded corners and that buttons can be used without issues no matter the sidebar position or if it's disabled

I really don't remember if I only modified this value because I changed other things too, but it has been a week now and everything working good with rounded corners, I'm on Windows 11 btw if that makes a difference. <Setter.Value> <WindowChrome CaptionHeight="25" CornerRadius="17" ResizeBorderThickness="4" NonClientFrameEdges ="None" UseAeroCaptionButtons="False" GlassFrameThickness="0"/> </Setter.Value>

darklinkpower commented 2 years ago

Already done some time ago but forgot to close