Notification Icon Visual Improvements

darklinkpower / Stardust

Theme inspired by GOG Galaxy 2.0 for Playnite Desktop Mode.

MIT License

69 stars 7 forks source link

Notification Icon Visual Improvements #22

Closed elkhaligy closed 2 years ago

elkhaligy commented 2 years ago

Feature Description

Current notification indicator looks out of place, improvements for it can be like the screenshot to match other elements, also I think it's better to make the notification icon static (not disappearing when there's no notifications) and what disappears is the notification number (disappears when it is 0)

Screenshots

old unknown new unknown new with 0 notification

darklinkpower commented 2 years ago

That Old icon is not correct, are you using a custom version or something? Maybe you used ThemeModifier? The icon is purple by default

Regarding the proposal:

The issue with the number backround is that the buttons already use the purple color for the background color
I'm not sure if I like the idea of having it shown permanently. The area is already pretty limited in PCs with high DPI/Lower resolutions so adding another button probably won't even fit in a lot of PCs. My screenshots are on 1080p 125% and it will be worse on other PCs.

elkhaligy commented 2 years ago

Strange thing, I remember fresh installing the theme and the notification icon remained same for me.

You are right regarding the limited space I actually hide most of the top bar items.

But I think it will be better for the icon to have the same background as other top bar items, because it really looks odd compared to them.

I wonder if playnite supports moving this notification icon on the sidebar or not, that will be a good thing for the narrow top bar area too.

darklinkpower commented 2 years ago

Something definitely caused the color change in your setup. You can verify that it uses the GlyphBrush (Purple color) here https://github.com/darklinkpower/Stardust/blob/master/source/Views/TopPanel.xaml#L139

But I think it will be better for the icon to have the same background as other top bar items, because it really looks odd compared to them.

I'm still not sure about this, I tried this and was not entirely convinced. The reason is that I think the notification button should look distinct enough to other buttons to make sure that the user notices it. I'll need to try again another time.

I wonder if playnite supports moving this notification icon on the sidebar or not, that will be a good thing for the narrow top bar area too.

Doing this is not possible and imo it wouldn't look right. There's also the issue again that space is limited.