darklinkpower / Stardust

Theme inspired by GOG Galaxy 2.0 for Playnite Desktop Mode.
MIT License
69 stars 7 forks source link

Add visual indicator of game state on Grid View #26

Closed Dorennor closed 2 years ago

Dorennor commented 2 years ago

Feature Description

It would be great if the purple highlight around the selected game (the one that appears after clicking the LMB) was automatically put on the game when you click the "play" or "info" button. Purely from an aesthetic point of view, it seems somehow logical to me.

Screenshots

No response

darklinkpower commented 2 years ago

Hello, I'm having trouble understanding what element specifically you are referring to. In what view is this? what do you mean by "LMB"? If possible, please share a screenshot of the element you are referring to

Dorennor commented 2 years ago

It was about violet border around active (choosen) element with LBM. image For example I will press LBM on game and this game will highlight with violet border. But if I will press LBM on button "Play" or button "I"(or "Info") it doesn't move on game that I've runed.

darklinkpower commented 2 years ago

If I understand right, I think by "LBM" you instead mean "LMB" which means Left Mouse Button right? This is a selection border but pressing the Play Button doesn't select the game. Adding this border could cause UX issues, as the game could be mistaken as being selected when it actually has not been selected. Perhaps another idea is to add a different visual indicator to games that are running or in other state, similar to how it's done on details view.

Dorennor commented 2 years ago

If I understand right, I think by "LBM" you instead mean "LMB" which means Left Mouse Button right? This is a selection border but pressing the Play Button doesn't select the game. Adding this border could cause UX issues, as the game could be mistaken as being selected when it actually has not been selected. Perhaps another idea is to add a different visual indicator to games that are running or in other state, similar to how it's done on details view.

Yes, sorry for my mistake about "LMB". Your idea generally reflects my suggestion: to create an indicator of a running game.

darklinkpower commented 2 years ago

Done in https://github.com/darklinkpower/Stardust/commit/9f07eb54b41aff04377f9b93418200abca7fbc8c