darklordabc / Legends-of-Dota-Redux

A Custom Game for Dota 2
http://steamcommunity.com/sharedfiles/filedetails/?id=786348190
52 stars 35 forks source link

make stat tomes stat bonuses work on your illusions #1346

Closed DankBudd closed 6 years ago

DankBudd commented 6 years ago

Ready to Merge

1342

darklordabc commented 6 years ago

I couldn't test this as it crashed for me. I would use the agi tome, and then cast mirror image to check if the illusions have the bonus stat, but it crashes right after casting mirror image.

DankBudd commented 6 years ago

uhh alright. i never had any crashing issues, but ill look into it

DankBudd commented 6 years ago

AllowIllusionDuplicate was making it crash, not really sure why that would be. it wasnt even calling OnCreated for the illusions before the crash.

i dont have a fix ready yet, i have it working for custom illusion skills but for volvos illusions i need a way to tie them to their creators and the unit they were created from, so i can manually give them the tome modifiers.

DankBudd commented 6 years ago

kind of a janky fix for volvos illusions, but it works.