darklow / django-suit

Modern theme for Django admin interface
http://djangosuit.com/
Other
2.31k stars 700 forks source link

django-cms missing styles #259

Open benjaoming opened 9 years ago

benjaoming commented 9 years ago

The "add subpage" and delete icons are missing. And the "Add page" in .object-tools is also missing.

Example:

screenshot from 2014-07-27 22 19 37

How it looks without suit:

screenshot from 2014-07-27 22 18 57

I would suggest looking at the following... but maybe it could use some of the django-suit icons... sorry that I don't have time to dig into your less compiling stuff... but hope this can maybe help....

#sitemap li a.addlink {
    padding-left: 12px;
    background: url('../img/icon_addlink.gif') no-repeat scroll 0px 0.2em transparent;
}

#sitemap li a.deletelink {
    padding-left: 12px;
    background: url('../img/icon_deletelink.gif') no-repeat scroll 0px 0.25em transparent;
}

.object-tools li a.addlink
{
    .btn();
    .btn-success();
}
darklow commented 9 years ago

Please read my comment regarding newest django-cms and support for it: https://github.com/darklow/django-suit/issues/213#issuecomment-39294600

benjaoming commented 9 years ago

@darklow I don't think you're far from the goal!! I use django-cms 3 every day together with suit, and it's just those buttons missing.

The rest, we've fixed upstream.

I beg you, please use a couple of minutes to get the missing buttons back, and I think the support level is absolutely reasonable :)

Not supporting django-cms3 for the BS3 is perfectly understandable, but at the same time, I think there's a probability that you'll get a PR for it.

darklow commented 9 years ago

By looking at your screenshot and the screenshot it was with 2.x cms version i would say i am pretty far from expected results - look at the screenshot here: https://github.com/darklow/django-suit/issues/77#issue-12843225

benjaoming commented 9 years ago

@darklow well, it's a matter of fixing the critical missing icons :) what i meant was that the rest of critical issues have been fixed.

Also, I think that actually django-cms 3 changed the columns of the Page change list.

If you have basic support, you can leave the polishing to the community perhaps? :)