darklow / django-suit

Modern theme for Django admin interface
http://djangosuit.com/
Other
2.32k stars 704 forks source link

The last row of inlines is not being showed when has_add_permission is set to False #725

Closed gokselcoban closed 5 years ago

gokselcoban commented 5 years ago

If adding an inline object is not permitted, the last row is not being showed.

Django==2.1+ (I tested with 2.1.7) django-suit==0.2.26

Related Django Commit: https://github.com/django/django/commit/825f0beda804e48e9197fcf3b0d909f9f548aa47#diff-2117a9b7a1b1a4c26dc70673b67b535dR28

gustavo-sdo commented 5 years ago

Hi @cobang, I sent a new pull request to resolve this issue, since @darklow always prioritizes backward compatibility of Django.

728

gokselcoban commented 5 years ago

Hi @gustavo-sdo, Thank you.

ahmedouvic commented 5 years ago

This issue is confirmed, i'm facing same issue, django suit has compatibility issues with inlines in django 2.1

jenarvaezg commented 5 years ago

I'm facing the same issue too

jenarvaezg commented 5 years ago

I can confirm that release v0.2.28 includes the fix, and this is working fine for me now! 👍

gokselcoban commented 5 years ago

Thank you.