search

darklow / django-suit

Modern theme for Django admin interface
http://djangosuit.com/
Other
2.31k stars 701 forks source link

Update V2 with bootstrap 4.5.x, bug corrected on horizontal filters, upgrade django version and more #774

Open pulse-mind opened 3 years ago

pulse-mind commented 3 years ago

In this pull request I've done a lot of improvements :

upgrade to bootstrap 4.5.x (with badges) upgrade to django 2.2.x upgrade node dependencies upgrade gulp script close #768 close #769 close #628 close #746 close #704 close #657 close #624 Work for #475

Please accept this pull request

bertini36 commented 3 years ago

What is the problem with this PR? Is it breaking something? :thinking:

pulse-mind commented 3 years ago

What is the problem with this PR? Is it breaking something? 🤔

I understood that darklow (the author, that did a very good job to build this) does not have time to spend on this project so this is it...

bertini36 commented 3 years ago

Ok, I understand. Thanks for the info @pulse-mind!

gamesbook commented 3 years ago

What is the problem with this PR? Is it breaking something? thinking

I understood that darklow (the author, that did a very good job to build this) does not have time to spend on this project so this is it... Unfortunately, in software, its not enough to build a good product - you also need to maintain it, or find someone else to maintain it.

pulse-mind commented 3 years ago

If you like you can go to my fork and use it. I am not going to improve it, but I am trying to maintain a part of it. I am still not using the v2 on production due to covid, my customer does not have time for now.

tjerkw commented 3 years ago

I think we should all join efforts in a single new django-suits-maintained branch and merge fixes there, what do you think.

See: https://github.com/darklow/django-suit/issues/781 https://github.com/darklow/django-suit/issues/475#issuecomment-856635914

tjerkw commented 3 years ago

https://github.com/darklow/django-suit/issues/781#issuecomment-859611044

pulse-mind commented 3 years ago

V2 is great and using last bootstrap version which is great. I've done the efforts to have it working. It seems fine for me and better than the V1!

pulse-mind commented 3 years ago

And I am agree to have only one branch for V2 in order to share our efforts. V1 is too old for everything.