search

darkmoonight / ToDark

📝 Task management application
MIT License
186 stars 23 forks source link

Question on permission: READ_EXTERNAL_STORAGE #52

Closed IzzySoft closed 2 months ago

IzzySoft commented 3 months ago

My scanner just got a few additional checks implemented, and on today's update of your app reported:

! repo/com.yoshi.todark_2037.apk declares risky permission(s): android.permission.READ_EXTERNAL_STORAGE

Could you please clarify what this permission is needed for? One needs Android 6 or higher to use the app, so I'd assume you'd use SAF (Storage Access Framework) for file system access. Are there any places outside its reach ToDark needs to access?

Thanks in advance for clarification!

Leonavichus commented 3 months ago

I used it to record backups.

SAF (Storage Access Framework)

I didn't know about it, thanks for telling me. I will try to remove the extension in the near future.

IzzySoft commented 3 months ago

There are some difficulties with storage access between Android 5 and 9, even with SAF (storage permissions are quite confusing there between Android versions). But if it's just about a single location to store backups, SAF should do: first time the user has to pick a location (via the file picker) to grant the app access to, and then the app could use that to read/write files. Some locations are not available this way (e.g. media directories or the Downloads directory) – but most places on external storage (except its root directory itself) can be picked from AFAIK.