search

darkreactions / ESCALATE_report

Transform experimental data into ML ready datasets!
http://escalation.sd2e.org/
MIT License
2 stars 1 forks source link

Cleanup devconfig sampler handling #58

Closed miketynes closed 4 years ago

miketynes commented 4 years ago

I was testing out this dfdumping PR on my new Linux machine with no Wolfram installed. The way devconfig was setup required me to isntall Wolfram before running. This install takes half an hour. I dont have that time, and this shouldnt be a feature of the code anyway.

Did some cleaning up.

Major points:

  1. I made a few changes. Intent behind changes is documented in comments. take what you like, drop what you dont.
  2. Whatever you do keep should probably be moved over to Capture as well. 2.1 Does the Report code even need to know about the sampler? could just remove this part entirely from Report devconfig and only make changes in Capture. Of course you may want to keep them the same to keep things simple. Just my $.02